Skip to content

fix(rendering): cap scene exit transitions at the scene's length - #2824

Merged
richiemcilroy merged 4 commits into
CapSoftware:mainfrom
yashranaway:fix/scene-exit-transition-length
Oct 22, 2026
Merged

richiemcilroy merged 4 commits into
CapSoftware:mainfrom
yashranaway:fix/scene-exit-transition-length

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

if a scene's exit transition is set longer than the scene itself, say a 2 second fade out on a 1 second camera only scene, the exit was timed from the scene's end, so it started before the scene even began. the moment the scene kicked in it was already partway through fading out, so the camera jumped.

now the exit transition is capped at the scene's length, which fixes both where it starts and how fast it eases, so it runs the whole scene and finishes on time. tested for camera only, hide camera, split and floating scenes, and the export and playback oracles pass.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no blocking issues remain.

Summary

Caps scene exit transitions at the scene’s length so short scenes start their exit at the right time.

  • Scene exits now finish within the scene’s length.

Reviews (2) · Last reviewed commit: "fix(rendering): use clamp for the scene ..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

1 similar comment
@richiemcilroy

Copy link
Copy Markdown
Member

@greptileai review

Comment thread crates/rendering/src/scene.rs Outdated
@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy
richiemcilroy merged commit fa6488e into CapSoftware:main Oct 22, 2026
41 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants