Repository navigation
fix(rendering): cap scene exit transitions at the scene's length - #2824
Merged
richiemcilroy merged 4 commits intoOct 22, 2026
Merged
richiemcilroy merged 4 commits into
richiemcilroy merged 4 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
1 similar comment
Member
|
@greptileai review |
Contributor
Author
|
@greptileai review |
# Conflicts: # crates/rendering/src/scene.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if a scene's exit transition is set longer than the scene itself, say a 2 second fade out on a 1 second camera only scene, the exit was timed from the scene's end, so it started before the scene even began. the moment the scene kicked in it was already partway through fading out, so the camera jumped.
now the exit transition is capped at the scene's length, which fixes both where it starts and how fast it eases, so it runs the whole scene and finishes on time. tested for camera only, hide camera, split and floating scenes, and the export and playback oracles pass.


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues remain.Summary
Caps scene exit transitions at the scene’s length so short scenes start their exit at the right time.
Reviews (2) · Last reviewed commit: "fix(rendering): use clamp for the scene ..." · Reviewed by Greptile