Repository navigation
fix(web): scope notification read updates to their recipient - #2877
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
marking a single notification as read checked that you were signed in, but then updated whatever notification id you sent, so anyone could mark someone else's notification as read. marking all of them was already limited to your own.
now both cases go through one update that always filters on the signed-in recipient, so there's no extra lookup and no gap between checking and writing. the test checks the actual sql for your own id, someone else's id and the mark-all case.
The PR appears safe to merge.Summary
markAsReadnow limits both individual and bulk updates to the signed-in recipient.No actionable issues found. Tests were inspected but not run.
Reviews (1) · Last reviewed commit: "fix(web): scope notification read update..." · Reviewed by Greptile