Repository navigation
fix(web): preserve recording dimensions in link previews - #2879
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link previews for share and embed pages always said the video was 1280x720, so portrait or odd sized recordings unfurled letterboxed in a 16:9 player on twitter, slack and iframely. the oembed endpoint already used the real size, the page metadata just never got it.
now both pages pass the stored width and height into the existing metadata builder, and it falls back to 1280x720 when they're missing or zero. tests cover portrait, missing and zero sizes.
The PR appears safe to merge; no actionable issues were found.Summary
Share and embed pages now pass stored recording dimensions to the shared metadata builder.
Review used source inspection. Tests were not run.
Reviews (1) · Last reviewed commit: "fix(web): preserve recording dimensions ..." · Reviewed by Greptile