Repository navigation
fix(web): keep daily analytics labels on their UTC date - #2880
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the analytics chart groups days in utc (each bucket is midnight utc), but the labels were formatted in the viewer's time zone. so for anyone west of utc every day showed up one date early, like january 1's views labelled dec 31.
now daily labels are formatted in utc so they match the bucket they belong to. hourly labels stay in local time since those are exact instants. the test renders the chart in three time zones around new year and a dst change.
The PR appears safe to merge.Summary
Keeps daily analytics labels on their UTC bucket dates.
Reviews (1) · Last reviewed commit: "fix(web): keep daily analytics labels on..." · Reviewed by Greptile