Repository navigation
fix(chrome-extension): preserve newer status during recording polls - #2881
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the extension's service worker polls the offscreen recorder for status, but that poll awaits twice before it writes. if the recorder broadcast a newer status in between, like finished or failed, the slow poll result landed after it and put the old recording controls back on the page.
now the poll remembers the status it started from and drops its result if anything changed while it was waiting, since that update is newer. tests delay the chrome callbacks to hit both waits.
The PR appears safe to merge.Summary
Prevents delayed recording polls from replacing a status received while the poll was waiting.
Reviews (1) · Last reviewed commit: "fix(chrome-extension): preserve newer st..." · Reviewed by Greptile