Repository navigation
fix(web): avoid restarting processing during thumbnail generation - #2885
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the claim that moves an upload into processing skipped videos already processing or complete, but not ones in the thumbnail phase. the media server sets that phase partway through a run, so a retried upload completion landing then would start a second full processing run, or fail with a confusing error if the phase changed under it.
now the thumbnail phase counts as already processing for implicit starts. the explicit retry still restarts a stale thumbnail phase on purpose. tests check the generated sql and the returned status.
The PR appears safe to merge; it blocks duplicate starts without removing explicit recovery.Summary
The PR prevents duplicate processing runs while a video is generating its thumbnail.
Tests were inspected but not run.
Reviews (1) · Last reviewed commit: "fix(web): avoid restarting processing du..." · Reviewed by Greptile