Skip to content

fix(desktop-gpui): keep camera preview alive when blur GPU setup fails - #2890

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/camera-blur-gpu-fallback
Oct 22, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/camera-blur-gpu-fallback

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

on linux setups where the gpu adapter can't run the camera blur shaders (opengl without the needed texture support), setting up blur hit a wgpu validation error, which wgpu turns into a panic. that killed the camera preview worker instead of using the existing fallback that shows raw frames when blur setup fails.

now blur setup runs inside a validation error scope and returns the error, so the preview logs it, marks blur unavailable and keeps going. the opt in test runs setup on an unsupported adapter and expects an error rather than a panic.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

The change catches GPU validation errors during camera blur setup and returns them to the existing preview fallback.

  • Camera preview keeps running when blur setup hits a GPU validation error.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): keep camera preview a..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit f002733 into CapSoftware:main Oct 22, 2026
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants