Repository navigation
fix(recorder-core): declare final Drive size at part boundaries - #2891
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
richiemcilroy merged 2 commits into
richiemcilroy merged 2 commits into
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the browser recorder uploads to google drive in 16 mb parts with an unknown total, and only the last request tells drive the final size. if a recording happened to stop right after an exact multiple of 16 mb had been flushed, there was nothing left to send, so no request ever declared the total and the drive upload stayed incomplete.
now when the buffer holds exactly a full drive part it keeps it until the next chunk or stop, so finishing always has a part to send with the real size. other providers are unchanged. tests stop at one and two part boundaries and check the final request.
The PR appears safe to merge.Summary
Keeps one full Google Drive part buffered so stopping at a part boundary still sends a request with the final size.
Reviews (1) · Last reviewed commit: "fix(recorder-core): declare final Drive ..." · Reviewed by Greptile