Repository navigation
fix(web): validate mobile reply parents - #2892
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Author
|
@greptileai review |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the mobile comment endpoint took the reply parent id as given. so someone allowed to comment on one video could reply to a comment from a different video, or to an emoji reaction, which linked comments across videos and could notify that other comment's author. nothing from the parent was exposed.
now a reply's parent has to be a text comment on the same video before anything is written, the same check the v1 and agent reply path already does, and a bad parent gets a 404 with no insert or notification. top level comments are unchanged.
The PR appears safe to merge.Summary
Mobile replies now require a text parent on the same video.
Reviews (1) · Last reviewed commit: "fix(web): validate mobile reply parents" · Reviewed by Greptile