Repository navigation
fix(web): finish recording jobs after transcription failures - #2893
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after a desktop recording is published, the finalize workflow queues transcription and retried forever if that failed. some failures never clear, like missing env vars or missing video info from the transcribe step, so those workflows sat sleeping and retrying every five minutes for good even though the recording itself was done.
now it tries 12 times with the same backoff, which covers about 38 minutes of a real outage, then finishes the already published recording and logs the failure. unconfigured and deleted cases still skip straight away. the test fails every enqueue and checks the workflow ends.
The PR appears safe to merge.Summary
Caps post-publication transcription enqueue attempts at 12 so a published recording’s workflow can finish after repeated failures.
Reviews (1) · Last reviewed commit: "fix(web): finish recording jobs after tr..." · Reviewed by Greptile