Skip to content

fix(desktop-gpui): honor height edits in locked crops - #2896

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/gpui-editor-crop
Oct 22, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/gpui-editor-crop

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

in the editor crop panel, typing a new height with an aspect ratio locked did nothing. the locked ratio is applied width first, and the setter passed the old width in, so it recomputed the height straight back. on a 960x540 crop at 16:9, entering 360 left it at 960x540 instead of 640x360.

now a height edit with a locked ratio works out the width from the new height first, then runs the same rounding and bounds clamping as before. width edits and drags are unchanged. tests cover 16:9 and 9:16, a height bigger than the source, and free crops.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Locked height edits now derive the width before applying the existing crop limits.

  • Typing a crop height now resizes locked crops from that height.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): honor height edits in..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy
richiemcilroy merged commit c7f1a9b into CapSoftware:main Oct 22, 2026
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants