Repository navigation
fix(desktop-gpui): honor height edits in locked crops - #2896
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the editor crop panel, typing a new height with an aspect ratio locked did nothing. the locked ratio is applied width first, and the setter passed the old width in, so it recomputed the height straight back. on a 960x540 crop at 16:9, entering 360 left it at 960x540 instead of 640x360.
now a height edit with a locked ratio works out the width from the new height first, then runs the same rounding and bounds clamping as before. width edits and drags are unchanged. tests cover 16:9 and 9:16, a height bigger than the source, and free crops.


Confidence Score: 5/5
The PR appears safe to merge.Summary
Locked height edits now derive the width before applying the existing crop limits.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): honor height edits in..." · Reviewed by Greptile