Skip to content

fix(desktop-gpui): ignore cancelled share export completions - #2897

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/cancelled-share-export-completion
Oct 22, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/cancelled-share-export-completion

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

if you cancelled or closed a share export just as the upload finished, the finished result still won. it overwrote your clipboard with the link, played the notification and showed the done state, and a requested close never happened because the panel was no longer busy.

now the completion checks for cancel or close first and goes back to idle, the same way a cancelled upload error and a clipboard export already do, and the link, sound and success state all happen in one ui update. the shared link metadata is still saved since the upload did land.

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Share-export completion now checks cancellation and close requests before showing success, copying the link, or playing a sound.

  • A cancelled or closing share export no longer takes over the panel when its upload finishes.

Reviews (1) · Last reviewed commit: "fix(desktop-gpui): ignore cancelled shar..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@richiemcilroy
richiemcilroy merged commit c76bd6e into CapSoftware:main Oct 22, 2026
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants