Repository navigation
fix(desktop-gpui): ignore cancelled share export completions - #2897
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
richiemcilroy merged 2 commits into
richiemcilroy merged 2 commits into
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you cancelled or closed a share export just as the upload finished, the finished result still won. it overwrote your clipboard with the link, played the notification and showed the done state, and a requested close never happened because the panel was no longer busy.
now the completion checks for cancel or close first and goes back to idle, the same way a cancelled upload error and a clipboard export already do, and the link, sound and success state all happen in one ui update. the shared link metadata is still saved since the upload did land.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Share-export completion now checks cancellation and close requests before showing success, copying the link, or playing a sound.
Reviews (1) · Last reviewed commit: "fix(desktop-gpui): ignore cancelled shar..." · Reviewed by Greptile