Repository navigation
fix(render-farm): clean up failed video outputs - #2898
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a render farm worker writes each video chunk to a temp h264 file in the project cache and only deleted it after the render and upload both worked. if the engine, the audio wait, the multipart upload or hls failed, the full chunk file stayed in the cache, and every retry wrote a new one with a fresh name, so failed jobs slowly filled the disk.
now the cleanup sits in a finally so every exit removes it. the diff is mostly re-indent from wrapping the body in try, it's about ten lines with whitespace hidden. the new test fails a render and checks the file is gone.
The PR appears safe to merge.Summary
Moves temporary video deletion into
finally, so failed renders and uploads also remove their output.Reviews (1) · Last reviewed commit: "fix(render-farm): clean up failed video ..." · Reviewed by Greptile