Repository navigation
fix(web): sign published MP4 storage keys - #2902
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a desktop recording publishes, it can keep a different output file than result.mp4 (the audio leveled one, for example), and the video's mp4 source already knows how to pick that key. but the share page playback url, the playlist redirect and the current download all hardcoded result.mp4, so those recordings got the older file or a missing one.
now those three paths ask the mp4 source for its file key, which still falls back to result.mp4 when nothing was retained and keeps the existing owner and video check on the stored key. tests cover a retained key and the fallback for each path.
The PR appears safe to merge; no actionable issues were found.Summary
The PR makes share playback, playlist redirects, and current downloads explicitly use the MP4 source’s selected storage key.
Reviews (1) · Last reviewed commit: "fix(web): sign published MP4 storage key..." · Reviewed by Greptile