Repository navigation
fix(rendering): let cursor smoothing settle after movement ends - #2904
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the smoothed cursor timeline only simulated 300 ms past the last cursor event. springs slower than that, including the built in smooth preset, were still moving when the timeline ended, so the cursor froze short of where the mouse actually stopped for the rest of the video.
now the simulation keeps going after the last event until the spring is at rest, which it already snaps to once it's close enough, with a five second cap so a zero friction custom spring can't run forever. the test moves the cursor once and checks it ends exactly on the final position.


Confidence Score: 5/5
The PR appears safe to merge.Summary
The PR lets cursor smoothing continue after the final recorded move until the spring rests, with a five-second limit.
Reviews (1) · Last reviewed commit: "fix(rendering): let cursor smoothing set..." · Reviewed by Greptile