Repository navigation
fix(chrome-extension): reset a recording phase left by a failed start - #2914
Merged
richiemcilroy merged 2 commits intoOct 22, 2026
Merged
richiemcilroy merged 2 commits into
richiemcilroy merged 2 commits into
Conversation
A throw from recorder.start() left status recording with no active session, so stop was a no-op and the document never idle-closed.
Contributor
|
@ManthanNimodiya is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
startRecordingsets status to"recording"before callingrecorder.start(). If that throws, the catch clearsactiveRecordingbut only reset"creating", so a capture phase was left with no session behind it: stop became a no-op, every tab's recording bar froze, and the recorder document never idle-closed. The catch now resets the phase this attempt set.Changes
apps/chrome-extension/src/offscreen/recorder.ts: reset"recording"as well as"creating"in the start failure pathChecklist
This change appears safe to merge.Summary
Fixes the stale recording phase when
recorder.start()fails.Reviews (1) · Last reviewed commit: "fix(chrome-extension): reset a recording..." · Reviewed by Greptile