Repository navigation
Isolate c8 temp dirs per coverage run - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-suite coverage reported 4.55% on host and sandbox while filtered runs reported 23%: scripts/coverage.test.mjs spawns nested coverage runs, and nested c8 (default --clean) wiped the outer run's shared .headlesscode/coverage/tmp/, deleting every profile collected before the extras phase. Only post-wipe profiles (nested claims run + last two extras) survived into the merge.
Fix: PID-unique --temp-directory per run plus best-effort cleanup on every exit path (profiles are tens of MB; the old shared tmp/ also broke concurrent runs). Regression test asserts no shared tmp/ returns, no non-pid tmp dirs, and no leftovers from finished nested runs.