Repository navigation
Stop session-launch token test leaking a real orchestrator per suite run - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testTokenGatesControlPlanePosts started the dashboard WITHOUT the fake CLI injected, so its good-auth POST spawned a real detached
--task x --mode multi-agent-orchestrator-headlesssession. The test never reaped it: every full suite run leaked one live orchestrator that burned real LLM tokens (~12k input) and then blocked on .harness.needs-decision forever. Found three accumulated hc-launch-* strays from past runs (cleaned up).Fix: inject the fake CLI like the other spawn tests, assert its marker file (proving the launch went to the fake), and SIGKILL + remove in finally. Verified standalone: all 8 tests pass, zero strays spawned, zero hc-launch dirs left.