Repository navigation
Retarget default RSI visible eval from rsi to engine suite - #145
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every fleet baseline failed its visible trial: DEFAULT_VISIBLE_EVALS ran
npm test -- --filter rsi, but fleet eval snapshots always omit src/rsi/ (alwaysOmit in openshell.ts — supervisor/evaluator sources are withheld from guests), so the filter matched zero files and exited 1. The omission predates nothing: the default (Sep 20) and the fleet omission (Sep 28) were never reconciled.Fix: default to
npm test -- --filter engine— the same target the proof path already uses for withheld-RSI runs (PROOF_VISIBLE_EVAL_COMMANDS). Verified: engine subset is 21 files, green, seconds-long. src/rsi/ stays omitted from snapshots (security boundary untouched).