Card: move Adventure and Omen to getAllPossibleAbilities

[Hanmac]

Now Card.updateSpellAbilities is clean from other shenanigans

[Hanmac]

@tool4ever is this ready?

[tool4ever]

no, I doubt it
this one seems way riskier than your previous #11654

have you even audited any one the many places where this gets used if they're now missing adventures? (ignore desktop, tests would complain)

[Hanmac]

@tool4ever shouldn't be a problem, there is nothing else looking for "isAdventure"

[tool4ever]

look I really don't have the time to do all this testing for you, especially when it feels like I have to proof my concerns first 😩

So here's my last input, after that is fixed someone else should check a few other cases:

Adventure spell is now unavailable

[Hanmac]

@tool4ever i updated getSpellsFromPlayEffect, so it should work again

[tool4ever]

yea I can confirm
guess I'll try to test the other 51 call sites during the weekend (if the weather isn't too nice)
also need to check #11700 for merge first probably

[tool4ever]

There are even more because some call getSpellAbilities or getNonManaAbilities on CardState directly

also this:

and getBasicSpells

hasSpellAbility seems safe

[Hanmac]

FirstSpellAbility should be the Intrinsic one anyway, not from a different CardState

[tool4ever]

adventure details text is now broken ingame

[Hanmac]

adventure details text is now broken ingame

more details:
Desktop or Mobile?

[tool4ever]

well both

[Hanmac]

You mean "Card Details" or "Card Picture"?

like they are shown in Card Picture:

and should not be shown in Card Details

IMO Prepared should not have been shown there, but you rejected #11634

[tool4ever]

it worked before, with your PR it doesn't

[Hanmac]

it worked before, with your PR it doesn't

You should read my post.

and should not be shown in Card Details

[tool4ever]

of course it needs to be shown in the GUI somewhere 👎

[Hanmac]

of course it needs to be shown in the GUI somewhere 👎

Like I said above, it is shown the "Card Picture" just not in "Card Details"

[tool4ever]

no, picture and details are two different tabs and can be used differently or only one of them

[Hanmac]

@tool4ever should be fixed