Fix iOS crash when importing decks from clipboard - #11782
Open
NickDeVeau wants to merge 1 commit into
Open
Conversation
Contributor
|
This seems to be the same cause as #8976 While this does add some overhead I wouldn't mind having this transformation done via code, as simply refactoring this class into indexes too might be a more messy alternative? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Opening Import from Clipboard initializes
DeckRecognizer. RoboVM's regex implementation rejects Java named capture syntax such as(?<pre>...), which raised aPatternSyntaxExceptionduring static initialization and terminated the iOS app with anExceptionInInitializerError.Testing
DeckRecognizerPortablePatternTestContribution note
The issue was reproduced and the fix was validated on-device by the contributor. OpenAI Codex assisted with diagnosis, implementation, test creation, and PR preparation.