Skip to content

fix: make esc cancel build to match advertised hint#70

Merged
jonoirwinrsa merged 1 commit intomainfrom
fix/esc-cancels-build
May 8, 2026
Merged

fix: make esc cancel build to match advertised hint#70
jonoirwinrsa merged 1 commit intomainfrom
fix/esc-cancels-build

Conversation

@jonoirwinrsa
Copy link
Copy Markdown
Contributor

Summary

  • The deploy view's help text reads esc or ctrl+c: cancel build, but the key handler at internal/ui/commands/deploy.go:832 only matched ctrl+c. Pressing esc during a build did nothing.
  • Updated the handler to also match tea.KeyEsc so the actual behavior matches what the hint already promises.

Test plan

  • Run cerebrium deploy in a TTY, start a build, press esc → build cancels cleanly
  • Repeat with ctrl+c → still cancels (regression check)
  • In --detach mode, esc exits without cancelling the build

🤖 Generated with Claude Code

The deploy view's help text says "esc or ctrl+c: cancel build" but the
key handler only matched ctrl+c, so esc did nothing during a build.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jonoirwinrsa jonoirwinrsa requested a review from wesrobin May 6, 2026 22:09
@jonoirwinrsa jonoirwinrsa added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit df2c568 May 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants