Skip to content

fix(app-store-ratings): last_over_time[31m] on reviews panel for 7d+ staleness - #2070

Open
Flotapponnier wants to merge 3 commits into
devfrom
fix/hl-main
Open

Flotapponnier wants to merge 3 commits into
devfrom
fix/hl-main

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Summary

  • app_store_reviews_total is scraped every 30 min; Prometheus default lookback is 5 min
  • For 7d/30d query_range with 2h step, ~5/6 of grid points fall outside the lookback window → denseSeriesFromMatrix returns null → 404 → "no data" in UI
  • Fix: wrap panel metric in last_over_time(…[31m]) so each step looks back up to 31 min, guaranteeing a sample per scrape cycle
  • 24h view was unaffected (served from materialized blob, not live Prom)

Test plan

  • ?view=reviews on 7d / 30d should now render the review-count series for all 11 providers
  • 24h view unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant