Skip to content

hotfix(prod): share cards for gauge benches, bench 265/234 sample counts, WebP-as-PNG logos (#2405) - #2406

Merged
Flotapponnier merged 1 commit into
mainfrom
hotfix/pf-share-card-samples
Sep 16, 2026
Merged

Flotapponnier merged 1 commit into
mainfrom
hotfix/pf-share-card-samples

Conversation

@Flotapponnier

Copy link
Copy Markdown
Collaborator

Cherry-pick of #2405 (dev) onto main, clean apply.

  • Gauge benches (p50 = p90 = p99) drop "by p50" and the p99 tails on share cards; compare panes labelled with the metric name.
  • Benches 265 and 234: sample_size counts scrapes, not 30-day fees in dollars ("124,240,646 samples" on the P/F card).
  • 20 logos under public/logos were WebP bytes with a .png/.jpg name (blank on Satori cards); converted in place.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HJgbZCqjR4nvCfcJSzofbw

…65/234 count scrapes as samples, not fees in dollars (#2405)

On perp-pf-ratio the ranking card read "Product ranking by p50" with
"p99 1.480x" under every bar, and the footer "124,240,646 samples": the
spec pointed sample_size at perp_protocol_fees_30d_usd, so the card
summed 30-day fees in dollars and called them samples. Both benches now
count scrapes of perp_protocol_health over 24h (about 1,440 per row),
and the methodology says so.

Cards: isGaugeBench() (every ranked row has p50 = p90 = p99) hides the
p99 captions, drops "by p50" from the ranking and leaderboard subtitles,
labels the compare panes with the metric name, and hides the p99 cell.
Latency benches unchanged.

Logos: 20 files under public/logos were WebP bytes with a .png/.jpg
name; Satori rendered them blank (the SynFutures column had an empty
gap). Converted to real PNG/JPEG, same names. Long labels on dense
ranking cards (SynFutures) shrink instead of clipping mid-word.

Claude-Session: https://claude.ai/code/session_01HJgbZCqjR4nvCfcJSzofbw

Co-authored-by: Flotapponnier <florent@mobula.io>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 59e15fe)
@Flotapponnier
Flotapponnier merged commit 08bb6ad into main Sep 16, 2026
1 check failed
@Flotapponnier
Flotapponnier deleted the hotfix/pf-share-card-samples branch September 16, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant