fiat-onramp-cost: Meld adapter verified live (POST + JSON body, BASIC base64(key), Meld-Version header) - #2409
Merged
Merged
Conversation
…ody, BASIC base64(key), Meld-Version header; partnerFee nullable The adapter was written from docs and would have failed twice: GET gives 405 (POST only) and base64(key + ":") gives 403 (the dashboard key is already id:secret). One local cycle with MELD_SANDBOX=true produces 6 quotes with the right labels. Sandbox rates are synthetic (+3,749 bps on BTC), so Meld stays out of the spec until a production key arrives. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L4rjxemTvgRwrCG6D2iK5D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live exercise of the Meld adapter, with the sandbox key received today.
Two blind-from-docs mistakes fixed: the endpoint is POST with a JSON body (GET → 405) and the auth is
BASIC base64(key)where the dashboard key is alreadyid:secret(base64(key + ":")→ 403).Meld-Version: 2025-03-04pinned,partnerFeeparsed as nullable, 400/404 mapped toErrNoQuote. One local harness cycle withMELD_SANDBOX=true→ 6 quotes, labelsvia=meld provider=banxa cohort=aggregator.Not deployed and Meld not added back to the spec: the key is sandbox-scoped (
api.meld.io→ 403) and sandbox rates are synthetic (BTC at 90,274 EUR vs 65,676 mid = +3,749 bps). Production key pending; CHECKLIST.md updated.🤖 Generated with Claude Code
https://claude.ai/code/session_01L4rjxemTvgRwrCG6D2iK5D