Feat: Implement Missing request timeout handling in frontend API calls#193
Open
Lansa-18 wants to merge 1 commit into
Open
Feat: Implement Missing request timeout handling in frontend API calls#193Lansa-18 wants to merge 1 commit into
Lansa-18 wants to merge 1 commit into
Conversation
Contributor
Author
|
@kilodesodiq-arch Kindly review the PR. Thank you. |
Contributor
|
@Lansa-18 please check, the CI didnt run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122
Feat: Request Timeout Handling for Frontend API Calls (#122)
Summary
Adds request timeout handling to all frontend API calls. Previously,
apiClient(openapi-fetch) delegated to nativefetchwith no timeout, meaning any network request would hang indefinitely if the backend was unresponsive — degrading UX especially in poor connectivity environments.The fix wraps
fetchClientwith anAbortController-based timeout at theapi-client.tslevel, so every existing and future API call inherits the 30s default automatically with no per-call changes needed.withRetryis also patched to not retry timed-out requests (which would have silently extended the hang by ~7s). Timeout errors surface a user-readable message instead of a silent hang.Testing
Unit Tests — New Utility
Covers:
DEFAULT_TIMEOUT_MS(30s) is used when no value is specifiedisTimeoutErrorcorrectly identifiesAbortErrorandTimeoutError, rejects plain errorsFull Test Suite — Regression Check
Type Check
pnpm type-check # clean, no outputBuild
pnpm build # ✓ Compiled successfully in 700msLint
Notes
No UI changes. Timeout errors surface through existing error states in TanStack Query consumers.
Checklist