Skip to content

fix(eth): serialize empty lists as [] instead of null#7214

Draft
sudo-shashank wants to merge 4 commits into
mainfrom
shashank/fix-accessList
Draft

fix(eth): serialize empty lists as [] instead of null#7214
sudo-shashank wants to merge 4 commits into
mainfrom
shashank/fix-accessList

Conversation

@sudo-shashank

@sudo-shashank sudo-shashank commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary of changes

Changes introduced in this pull request:

  • Use NotNullVec instead of Vec for empty lists so they serialize as [] instead of null.

Reference issue to close (if applicable)

Closes #7205

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

Bug Fixes

  • Fixed Ethereum JSON-RPC methods to serialize empty lists as [] instead of null. Affected methods include eth_accounts, eth_getBlockReceipts, trace_block, trace_transaction, and related trace endpoints.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5576cfac-424e-4d6c-a782-1b481b87d100

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shashank/fix-accessList
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch shashank/fix-accessList

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank added the RPC requires calibnet RPC checks to run on CI label Jun 22, 2026
@sudo-shashank sudo-shashank marked this pull request as ready for review June 22, 2026 06:34
@sudo-shashank sudo-shashank requested a review from a team as a code owner June 22, 2026 06:34
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and hanabi1224 and removed request for a team June 22, 2026 06:34
@sudo-shashank sudo-shashank marked this pull request as draft June 22, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eth_getblockByNumber possible discrepancy on accessList

1 participant