Merged
Conversation
Closed
Closed
qdm12
force-pushed
the
qdm12/build/go1.19
branch
from
8ca1703 to
5358ca9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2719 +/- ##
===============================================
+ Coverage 51.42% 51.46% +0.04%
===============================================
Files 219 219
Lines 28009 28009
===============================================
+ Hits 14403 14415 +12
+ Misses 12320 12309 -11
+ Partials 1286 1285 -1 |
qdm12
force-pushed
the
qdm12/build/go1.19
branch
7 times, most recently
from
98b46a9 to
7642d49
Compare
qdm12
requested review from
EclesioMeloJunior,
edwardmack,
jimjbrettj,
kishansagathiya,
noot and
timwu20
as code owners
qdm12
force-pushed
the
qdm12/build/go1.19
branch
from
7642d49 to
b74f47b
Compare
EclesioMeloJunior
approved these changes
Jan 16, 2023
Contributor
kishansagathiya
left a comment
kishansagathiya
left a comment
There was a problem hiding this comment.
Upgrade to Go 1.19 is good.
Not directly relevant, but there are a lot of space removals, which is alright. Are they by-product of linter?
but I don't see the point of some the other changes that I have put ? on.
kishansagathiya
approved these changes
Jan 17, 2023
qdm12
force-pushed
the
qdm12/build/go1.19
branch
from
b74f47b to
29bdaad
Compare
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ioutilimport withos//gocyclo:ignorecommentTests
Issues
Fixes #2768
Primary Reviewer
@EclesioMeloJunior