fix(tests): use numeric id fixtures in flow-config schema tests - #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfailspnpm testin@chatbotx.io/flow-config. #1069 anchoredzodBigintAsStringto/^\d+$/, and #1104 updated the worker and business fixtures that broke — but eight flow-config test files still carry the old"step-1"-shaped ids and now fail validation (26 tests across 8 files).This PR is fixtures only — no production code changes.
Changes
Only ids that a
zodBigintAsString()schema field validates are changed; fields that are plainz.string()(template.id,nodeId, edge ids, image ids) are left as they are.appointment-scheduling-schema.test.ts— stepidandcalendarId→ numericimport-export.test.ts— condition stepid,otherwiseIdand caseidin the fixture flow → numericmessenger-template.test.ts— stepidand buttonid(plus the matchingtoMatchObjectassertion) → numericopenai-compatible-ai-steps.test.ts—aiAgentId→ numeric (both the accept and reject cases, so the reject case fails for the intended reason)send-multiple-images.test.ts,tiktok-text-rules.test.ts,wa-template-mpm-rules.test.ts,wa-template-quick-reply-buttons.test.ts— stepid→ numericTest plan
pnpm --filter @chatbotx.io/flow-config test— 35 files, 437 testspnpm --filter builder test— 407 files, 2726 testspnpm turbo run test --continue— every other workspace greenpnpm lintpnpm --filter @chatbotx.io/flow-config check-types