Skip to content

fix(tests): use numeric id fixtures in flow-config schema tests - #1106

Merged
viethung0o0 merged 1 commit into
mainfrom
fix/flow-config-numeric-id-fixtures
Sep 6, 2026
Merged

fix(tests): use numeric id fixtures in flow-config schema tests#1106
viethung0o0 merged 1 commit into
mainfrom
fix/flow-config-numeric-id-fixtures

Conversation

@viethung0o0

Copy link
Copy Markdown
Contributor

Summary

main fails pnpm test in @chatbotx.io/flow-config. #1069 anchored zodBigintAsString to /^\d+$/, and #1104 updated the worker and business fixtures that broke — but eight flow-config test files still carry the old "step-1"-shaped ids and now fail validation (26 tests across 8 files).

This PR is fixtures only — no production code changes.

Changes

Only ids that a zodBigintAsString() schema field validates are changed; fields that are plain z.string() (template.id, nodeId, edge ids, image ids) are left as they are.

  • appointment-scheduling-schema.test.ts — step id and calendarId → numeric
  • import-export.test.ts — condition step id, otherwiseId and case id in the fixture flow → numeric
  • messenger-template.test.ts — step id and button id (plus the matching toMatchObject assertion) → numeric
  • openai-compatible-ai-steps.test.tsaiAgentId → numeric (both the accept and reject cases, so the reject case fails for the intended reason)
  • send-multiple-images.test.ts, tiktok-text-rules.test.ts, wa-template-mpm-rules.test.ts, wa-template-quick-reply-buttons.test.ts — step id → numeric

Test plan

  • pnpm --filter @chatbotx.io/flow-config test — 35 files, 437 tests
  • pnpm --filter builder test — 407 files, 2726 tests
  • pnpm turbo run test --continue — every other workspace green
  • pnpm lint
  • pnpm --filter @chatbotx.io/flow-config check-types

@github-actions github-actions Bot added the bug Something isn't working as expected label Sep 6, 2026
@viethung0o0
viethung0o0 marked this pull request as ready for review September 6, 2026 11:56
@viethung0o0
viethung0o0 merged commit f92f4f8 into main Sep 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants