Handling buffer data, not just file paths ✨#141
Open
kw0n0 wants to merge 3 commits intoChetanXpro:mainfrom
Open
Handling buffer data, not just file paths ✨#141kw0n0 wants to merge 3 commits intoChetanXpro:mainfrom
kw0n0 wants to merge 3 commits intoChetanXpro:mainfrom
Conversation
MrSwitch
reviewed
Feb 18, 2025
Comment on lines
+38
to
+40
| const tempInputPath = `Nodejs-whisper-input_${Date.now()}` | ||
| fs.writeFileSync(tempInputPath, inputAudioSrc) | ||
| logger.debug(`[Nodejs-whisper] Temporary input file created: ${tempInputPath}`) |
Contributor
There was a problem hiding this comment.
It looks like the output is the name of this wav file plus ".srt" or ".json" or ".vtt" etc..
So with this change having a generated filepath to the .wav would make the corresponding output file paths indeterminate.
(at least that's my understanding #120 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First attempt to handling buffer data, refer to #140
With this change:
Change variable name(filePath - audioSrc)
Add logic when receiving buffer data
I've created a simple example, but I'll post a PR for more if needed