set vim editor alias only if vim not present - #212
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PowerShell profile removes existing ChangesEditor alias handling
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Microsoft.PowerShell_profile.ps1`:
- Around line 293-295: Update the vim binding logic to check the installed
executable via Get-Command -Name vim -CommandType Application rather than
comparing $EDITOR. Preserve an existing installed vim application binding, and
remove any stale vim alias that points to vim before relying on direct vim.exe
resolution during profile reloads.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3296fe2b-2109-4714-9c75-8b8577bffcca
📒 Files selected for processing (1)
Microsoft.PowerShell_profile.ps1
Summary
I have had vim installed but could not open it in powershell since the created alias pointed to itself.
Type Of Change
Testing
Manually tested on my machine.
Checklist