Open
Conversation
reneemeyer
suggested changes
Oct 28, 2018
02week/pigLatin.js
Outdated
| if(vowelPosition == 0){ | ||
| return word + "yay" | ||
| } | ||
| let mainString = word.split(""); |
02week/pigLatin.js
Outdated
| let mainString = word.split(""); | ||
| const firstConsonants = mainString.splice(0,vowelPosition).join(""); | ||
| //not sure if there is a single line way to do this, settled on this. Still thinking about it | ||
| mainString = mainString.join("") + firstConsonants + "ay" |
There was a problem hiding this comment.
you're mutating this variable a lot here and it's unnecessary, join the array and return this. return mainString.join("") + firstConsonants + "ay"
02week/pigLatin.js
Outdated
| } | ||
| if (!letterIsValid){ | ||
| //if letter is still invalid the entire string is invalid | ||
| return 0; |
There was a problem hiding this comment.
just return the evaluation, there's no need to return 0 or 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3