fix(input): select empty-value options by text - #2501
Merged
Lightning00Blade merged 1 commit intoAug 10, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Lightning00Blade
self-requested a review
August 10, 2026 10:40
Lightning00Blade
enabled auto-merge
August 10, 2026 11:12
Merged
via the queue into
ChromeDevTools:main
with commit Aug 10, 2026
b969c45
26 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression evidence
Before:
npx --yes -p node@24 -c 'node --version && npm run test tests/tools/input.test.ts -- --test-name-pattern=empty.value.by.text'exited1After:
npx --yes -p node@24 -c 'node --version && npm run test tests/tools/input.test.ts -- --test-name-pattern=empty.value.by.text'exited0Verification
npx --yes -p node@24 -c 'node --version && npm run test tests/tools/input.test.ts'npx --yes -p node@24 -c 'node --version && npm run build'npx --yes -p node@24 -c 'node --version && npm run check-format'npx --yes -p node@24 -c 'node --version && npm run gen'The full
npm run testwas also attempted. On this machine it reaches anunrelated Chrome 151
Page.captureScreenshot: Page is too largefailure; thesame screenshot test fails identically on the exact unmodified base SHA under
Node 24. The complete affected input test suite passes.
Scope