fix(loadResource): re-validate URL policy after redirects - #2503
Open
jatinsingh1603 wants to merge 1 commit into
Open
fix(loadResource): re-validate URL policy after redirects#2503jatinsingh1603 wants to merge 1 commit into
jatinsingh1603 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
recheck |
loadResource() only checked the allow/block list against the initial request URL. An allowed origin could redirect to a blocked (or otherwise disallowed) destination and the fetch would follow it without any further policy check. Fetch redirects are now followed manually so each hop's target is re-validated against the allow/block list before it is followed. Fixes ChromeDevTools#2502
jatinsingh1603
force-pushed
the
fix/redirect-bypasses-url-allow-blocklist
branch
from
August 8, 2026 07:06
8122b31 to
159d91f
Compare
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadResource()only validated the allow/block list against the initial request URL. If a URL that passed policy responded with an HTTP redirect (e.g. a 302), the built-infetch(..., {redirect: 'follow'})behavior followed it to the final destination without re-checking that destination against the configured policy. An allowed origin could therefore redirect to a URL the policy was specifically configured to block.This PR follows redirects manually (
redirect: 'manual') and re-validates every hop's target against#validateUrlNotBlocked/#validateUrlAllowedbefore following it.Fixes #2502
Test plan
tests/McpContext.test.tscovering: redirect target rejected by blocklist, redirect target rejected by allowlist, and a normal allowed redirect chain still resolving successfully.npm run typechecknpm run check-formatnode scripts/test.js tests/McpContext.test.ts(all passing)