Add Docker support for production deployment#461
Open
PedroLiu1999 wants to merge 1 commit intoChurchApps:mainfrom
Open
Add Docker support for production deployment#461PedroLiu1999 wants to merge 1 commit intoChurchApps:mainfrom
PedroLiu1999 wants to merge 1 commit intoChurchApps:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Live Church Solutions Team on Vercel. A member of the Team first needs to authorize it. |
jzongker
reviewed
Apr 3, 2026
src/helpers/EnvironmentHelper.ts
Outdated
| }; | ||
|
|
||
| static applyCommonEnvOverrides = () => { | ||
| EnvironmentHelper.Common.AttendanceApi = process.env.REACT_APP_ATTENDANCE_API || process.env.NEXT_PUBLIC_ATTENDANCE_API || EnvironmentHelper.Common.AttendanceApi; |
Contributor
There was a problem hiding this comment.
Thanks. The other changes all look good. This function doesn't need to exist though. Instead you can make modifications to https://github.com/ChurchApps/Packages/blob/main/helpers/src/CommonEnvironmentHelper.ts
Author
There was a problem hiding this comment.
Now removed the last commit. It's only adding the docker file in this pull request now. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces Docker support to streamline deployment and ensure environmental consistency. By containerizing the application, we decouple the build and runtime environments, ensuring the application runs identically on any Docker-capable host.