Skip to content

Remove an unused logo component and stale commented code - #25

Merged
Charlie-Carson merged 1 commit into
mainfrom
maint-cleanup-2026-10-24
Oct 25, 2026
Merged

Charlie-Carson merged 1 commit into
mainfrom
maint-cleanup-2026-10-24

Conversation

@Charlie-Carson

Copy link
Copy Markdown
Contributor

Summary

  • Remove dead code (no behavior change):
    • Deleted the unused FreePlayLogoWhite component and its barrel export.
    • Deleted two commented-out blocks in src/components/Message.tsx, an old getMessageType and an old getContent. They date from 2026-02-03, carry no explanation, and the live getMessageType below them replaces them.

Evidence

  • knip, run with App.tsx, plugins/*.js and .maestro/scripts/*.js as entry points, flagged FreePlayLogoWhite, and git grep -w FreePlayLogoWhite finds only its declaration and the barrel line. git blame dates every line in both commented blocks to 2026-02-03.
  • Kept: Utilities. It is unused, but it is the only import of @react-native-firebase/analytics, and the helpers barrel loads it at startup. Also kept: PrivacyPolicyScreen.tv.tsx, a platform file, and the native-module dependencies.
  • JS-only change, so EAS Update ships it over the air once merged.

Proof

  • yarn tsc --noEmit: the same 3 errors on origin/main and on this branch, with an identical list. They are pre-existing @churchapps/content-providers type mismatches in the lane.
  • yarn eslint on the changed files: clean.
  • yarn jest: 14 suites, 124 tests passed.
  • yarn expo export --platform android: bundle built (5.58 MB hbc).
  • No behavior change.

@Charlie-Carson
Charlie-Carson merged commit 76d4c5c into main Oct 25, 2026
1 check failed
@Charlie-Carson
Charlie-Carson deleted the maint-cleanup-2026-10-24 branch October 25, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant