Repository navigation
Keep classroom and external provider pages out of search - #486
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/classroom/:idand/external/*out of search results (noindex, followlayouts, same pattern as/embed). Both pages render only in the browser behind the generic "Lessons.church" title. They answer 200 for any id. The lessons they show already have their own indexed pages: classroom pages repeat Lessons.church lessons, and external pages show another provider's curriculum.Evidence
/classroom/nopeand/external/nope/nopeboth returned 200 with title "Lessons.church", no description, no canonical and no robots meta. Neither is disallowed in robots.txt.Proof
npx playwright test seo.spec.ts -g "classroom|external"(slot 5, temporary config without the global setup) on main: 2 failed. With the layouts, the fullseo.spec.tsgives 19 passed.npx tsc --noEmitclean.npx eslinton the changed files clean.