nd_interface_vpc_access#279
Open
allenrobel wants to merge 3 commits into
Open
Conversation
allenrobel
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
mikewiebe,
mtarking,
sajagana,
samiib and
shrsr
as code owners
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
b03db99 to
c3c54fd
Compare
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
c3c54fd to
2e09054
Compare
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
2e09054 to
0ddf68c
Compare
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
0ddf68c to
9228400
Compare
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
9228400 to
82a2549
Compare
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
09aa4bd to
a0c2186
Compare
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
a0c2186 to
31b969d
Compare
Scaffolding for the nd_interface_vpc_access module: policy type literal for the int_vpc_access_host template, hardcoded into the feature model per the per-policy module convention. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Manages vPC accessVpcHost interfaces (template int_vpc_access_host) on
Cisco Nexus Dashboard, inheriting CRUD, peer-serial resolution,
per-interface DELETE, and query_all dedupe from VpcBaseOrchestrator.
Access-specific design:
- Single user-facing access_vlan field that fans out to peer1AccessVlan /
peer2AccessVlan at payload-serialization time. ND collapses both per-peer
keys back to a single accessVlan in the GET response, so the round-trip
matches the wire echo without further normalization. Marked TODO(4.2.1)
on the model_serializer.
- Keeps per-peer peer1/peer2 member_ports / port_channel_id /
port_channel_description / port_channel_configuration as the OpenAPI
schema preserves these on read.
- Identifier strategy is single (interface_name only); switch_ip is
routing-only and excluded from diff/payload because ND echoes the same
vPC record from BOTH peers' /interfaces GETs.
Includes:
- AccessVpcHostInterfaceModel (model) + AccessVpcHostInterfaceOrchestrator
(~50-line VpcBaseOrchestrator subclass that sets model_class and returns
{"accessVpcHost"} for _managed_policy_types).
- Unit tests (model + orchestrator + fixture JSON).
- Integration target with merged / replaced / overridden / deleted state
blocks; vPC pair setup/teardown via nd_vpc_pair.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
YAML 1.1 parses an unquoted `on` as the boolean True, so the DOCUMENTATION block's `choices: [ on, active, passive ]` resolved to `[True, 'active', 'passive']` while the argument_spec correctly used the string 'on'. This tripped two ansible-test validate-modules checks: doc-choices-do-not-match-spec and doc-choices-incompatible-type. Quote 'on' so the documented choices parse as strings and match the spec. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
allenrobel
force-pushed
the
nd_interface_vpc_access
branch
from
31b969d to
3a61f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Proposed Changes
nd_interface_vpc_accessmodule, which manages vPCaccessVpcHostinterfaces (templateint_vpc_access_host) on Cisco Nexus Dashboard.AccessVpcHostPolicyTypeEnumtoplugins/module_utils/models/interfaces/enums.pyso the model can frozen-pin itspolicy_type.query_alldedupe fromVpcBaseOrchestrator(introduced in the stack-parent PR).Access-specific design (lab-verified on ND 4.2.1):
access_vlanfield fans out topeer1AccessVlan/peer2AccessVlanat payload-serialization time via a@model_serializer. ND collapses both per-peer keys back to a singleaccessVlanin the GET response, so the round-trip matches the wire echo without further normalization. TaggedTODO(4.2.1).peer1/peer2member_ports/port_channel_id/port_channel_description/port_channel_configurationare exposed (the OpenAPI schema preserves these on read).identifier_strategy = "single"oninterface_name;switch_ipis routing-only and excluded from diff/payload because ND echoes the same vPC record from BOTH peers'/interfacesGETs.Test Notes
python -m pytest tests/unit/module_utils/models/test_vpc_access_interface.py tests/unit/module_utils/orchestrators/test_vpc_access_interface.py -q. Full repo suite stays green (926 pass, no regressions).tests/integration/targets/nd_interface_vpc_access/withmerged/replaced/overridden/deletedstate coverage, exercised against ND 4.2.1 on the SITE1 lab (S1_LE1 / S1_LE2):ansible-test integration --docker nd_interface_vpc_access -vv.ansible-test sanity --docker default --python 3.11passes on the changed files.peer1AccessVlan+peer2AccessVlanreturns 207 success; GET echoes a singleaccessVlanmatching what the model exposes.Cisco Nexus Dashboard Version
4.2.1
Related ND API Resource Category
Checklist