This repository was archived by the owner on Feb 6, 2019. It is now read-only.
Add support for KV.txn and add a Lock class#2
Open
ducdigital wants to merge 6 commits intoCitySim:masterfrom
Open
Add support for KV.txn and add a Lock class#2ducdigital wants to merge 6 commits intoCitySim:masterfrom
ducdigital wants to merge 6 commits intoCitySim:masterfrom
Conversation
Owner
|
hi, |
The problem with etcd proto is that if we use it's class in an OOP way it does not really work.
Add Lock functionality Fix problem of transaction cause of using nested classes of proto object. it does not really work
Author
|
Hey there I just update the Transaction class and add a Lock class. Lock class is "almost" direct implementation of the Python's version. I also update Transaction class to fix the problem cause by nested proto class object (It does not really work that way and I am not sure why). As soon as I change everything to a normal object It work very well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage:
PS: This is experimental just to kick start the idea. It works but the code is not as clean as the original code base. Might need some refactoring work.