Skip to content

Fix. fixed screenshot function - #127

Merged
veronika-tseleva-cleantalk merged 2 commits into
devfrom
fix_55346
Sep 3, 2026
Merged

Fix. fixed screenshot function#127
veronika-tseleva-cleantalk merged 2 commits into
devfrom
fix_55346

Conversation

@veronika-tseleva-cleantalk

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings September 2, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The screenshot is scheduled asynchronously via setTimeout, so it runs after the surrounding try/finally restores widget display state, making the current control flow misleading/ineffective at capture time.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the widget’s “automatic screenshot on open” behavior in the SpotFix/CleanTalk Doboard widget by adding guards around screenshot capture and deferring the capture call.

Changes:

  • Replaced the direct await makeScreenshot() call with a guarded, delayed screenshot invocation.
  • Applied the same change to the built distribution bundle.
File summaries
File Description
js/src/widget.js Adds conditional + delayed automatic screenshot trigger when opening the widget.
dist/doboard-widget-bundle.js Mirrors the same screenshot-trigger change in the built bundle output.
Review details
  • Files reviewed: 1/4 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread js/src/widget.js Outdated
Copilot AI review requested due to automatic review settings September 2, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated getAllTasks() condition makes API fetching effectively unconditional in normal mode, adding unnecessary network/latency and diverging from existing WS-driven refresh behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 2/5 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread js/src/handlers.js
@veronika-tseleva-cleantalk
veronika-tseleva-cleantalk merged commit 42e3759 into dev Sep 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants