Skip to content

Udp.Code. Unify FW logs - #727

Open
alexander-b-clean wants to merge 1 commit into
devfrom
unify-fw-logs.ab
Open

Udp.Code. Unify FW logs#727
alexander-b-clean wants to merge 1 commit into
devfrom
unify-fw-logs.ab

Conversation

@alexander-b-clean

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new logging selection can record a test result even when the actual request was denied by a different module, making logs inconsistent with real blocking behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adjusts firewall logging to prefer logging a “test block” result (when running in test mode) instead of the final reduced firewall result, aiming to unify/standardize firewall log entries in those scenarios.

Changes:

  • Update the run() flow to pass $this->test_block into updateLog() when it is set, falling back to the final $result otherwise.
File summaries
File Description
lib/CleantalkSP/Security/Firewall.php Changes log update behavior to log the test-block result when present instead of the reduced final result.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread lib/CleantalkSP/Security/Firewall.php
@alexander-b-clean alexander-b-clean changed the title Unify fw logs.ab Udp.Code. Unify FW logs Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants