Udp.Code. Unify FW logs - #727
Open
alexander-b-clean wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new logging selection can record a test result even when the actual request was denied by a different module, making logs inconsistent with real blocking behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adjusts firewall logging to prefer logging a “test block” result (when running in test mode) instead of the final reduced firewall result, aiming to unify/standardize firewall log entries in those scenarios.
Changes:
- Update the
run()flow to pass$this->test_blockintoupdateLog()when it is set, falling back to the final$resultotherwise.
File summaries
| File | Description |
|---|---|
| lib/CleantalkSP/Security/Firewall.php | Changes log update behavior to log the test-block result when present instead of the reduced final result. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Glomberg
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/42252