throw an exception if project-rename has duplicate columns#370
Open
bemitc wants to merge 530 commits intoKusto-phase3from
Open
throw an exception if project-rename has duplicate columns#370bemitc wants to merge 530 commits intoKusto-phase3from
bemitc wants to merge 530 commits intoKusto-phase3from
Conversation
Enable pr sanity checks
Fix epoch related issue
isascii() function
bug_fix_2512
bug_fix_2511
Implement a very toned-down version of hll functions
ltrk2
suggested changes
Jul 24, 2023
| class ParserKQLStatement : public IParserBase | ||
| { | ||
| public: | ||
| explicit ParserKQLStatement() = default; |
There was a problem hiding this comment.
I don't think there should be a default constructor, because otherwise you'd encounter cases where your solution wouldn't be able to function.
kashwy
force-pushed
the
Kusto-phase3
branch
from
36d6fe2 to
61e14cd
Compare
kothiga
force-pushed
the
Kusto-phase3
branch
2 times, most recently
from
1e1f94f to
3fab19c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
throw an exception if project-rename has duplicate columns