Centralize package version mgt#312
Open
alex-clickhouse wants to merge 1 commit intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces NuGet Central Package Management for the solution by moving package version declarations into a new Directory.Packages.props, simplifying dependency upgrades across projects.
Changes:
- Added
Directory.Packages.propswith centrally managed package versions (and aClickHouseDriverVersionproperty). - Removed per-project
Version="..."attributes from multiple.csprojfiles to rely on central versions. - Updated benchmark comparison mode to use centrally managed
ClickHouse.Driverpackage versioning.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/ClickHouse.Driver.Examples.csproj | Removes inline package versions so examples consume centrally managed versions. |
| Directory.Packages.props | New central package/version registry for the repo (enables CPM). |
| ClickHouse.Driver/ClickHouse.Driver.csproj | Removes inline versions for runtime/analyzer dependencies. |
| ClickHouse.Driver.Tests/ClickHouse.Driver.Tests.csproj | Removes inline test/dependency versions to rely on central versions. |
| ClickHouse.Driver.IntegrationTests/ClickHouse.Driver.IntegrationTests.csproj | Removes inline test/dependency versions to rely on central versions. |
| ClickHouse.Driver.Benchmark/ClickHouse.Driver.Benchmark.csproj | Removes inline versions and centralizes benchmark comparison package version control. |
alex-clickhouse
force-pushed
the
packages-props
branch
from
ca6a07d to
ec60fc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves package versions to a single props file, will make package version upgrades a bit easier.