Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
matrix:
# most recent LTS releases as well as latest stable builds
# https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Aopen+is%3Apr+label%3Arelease
clickhouse: ["25.8", "26.3", "latest"]
clickhouse: ["26.3", "26.6", "26.7", "26.8", "latest"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be only LTS. And latest LTS that reached EOL (25.8)
Here is final list
25.8, 26.3, 26.8, latest

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the final list. Understood: 25.8, 26.3, 26.8, latest.

This list differs from the version-coverage policy we apply across the client repos (the 3 newest series plus the 2 newest LTS series), which gives 26.3, 26.6, 26.7, 26.8. We are confirming the exception for this repo on our side. We will then update the PR. No action is necessary from you now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As maintainer I can confirm that we need to take one EOL LTS - 25.8

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An update on my earlier reply, and an apology for the delay.

I could not get a decision on a policy exception on our side, so I have not changed the version list. I do not have the authority to replace our cross-repo coverage policy with an LTS-only list on my own.

The PR as it stands keeps 26.3, 26.6, 26.7, 26.8, latest — the 3 newest series plus the 2 newest LTS series. All new version legs pass; the only red checks are the known CH-cloud credential legs, which are unrelated to this diff.

The merge decision is yours. Please merge, close, or hold this PR, as you prefer. One thing that is useful to know: our weekly version check keeps no state and re-derives coverage every run, so if this is closed the repo is reported as off-policy again and the task returns. A permanent answer therefore needs an agreement between you and the ClickHouse integrations team on the coverage rule for clickhouse-java, not another PR from me. I have asked our side to start that conversation.

I will not push a change to this list unless our team agrees to the exception, and I will not keep re-opening this point with you.

project: ["clickhouse-http-client", "client-v2"]
fail-fast: false
timeout-minutes: 15
Expand Down Expand Up @@ -303,7 +303,7 @@ jobs:
needs: test-java-client
strategy:
matrix:
clickhouse: ["25.8", "26.3", "latest"]
clickhouse: ["26.3", "26.6", "26.7", "26.8", "latest"]
# here http, http_client and apache_http_client represent different value of http_connection_provider
# protocol: ["http", "http_client", "apache_http_client"]
protocol: ["apache_http_client"]
Expand Down Expand Up @@ -363,7 +363,7 @@ jobs:
needs: test-jdbc-driver
strategy:
matrix:
clickhouse: ["25.8", "26.3", "latest"]
clickhouse: ["26.3", "26.6", "26.7", "26.8", "latest"]
# grpc is not fully supported, and http_client and apache_http_client do not work in CI environment(due to limited threads?)
protocol: ["http"]
r2dbc: ["1.0.0.RELEASE", "0.9.1.RELEASE"]
Expand Down
Loading