-
Notifications
You must be signed in to change notification settings - Fork 637
ci(workflows): update CH version matrix to 26.8, 26.7, 26.6, 26.3 #3131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
polyglotAI-bot
wants to merge
1
commit into
main
Choose a base branch
from
polyglot/ci-ch-version-matrix-26-8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be only LTS. And latest LTS that reached EOL (25.8)
Here is final list
25.8, 26.3, 26.8, latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the final list. Understood: 25.8, 26.3, 26.8, latest.
This list differs from the version-coverage policy we apply across the client repos (the 3 newest series plus the 2 newest LTS series), which gives 26.3, 26.6, 26.7, 26.8. We are confirming the exception for this repo on our side. We will then update the PR. No action is necessary from you now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As maintainer I can confirm that we need to take one EOL LTS - 25.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An update on my earlier reply, and an apology for the delay.
I could not get a decision on a policy exception on our side, so I have not changed the version list. I do not have the authority to replace our cross-repo coverage policy with an LTS-only list on my own.
The PR as it stands keeps
26.3, 26.6, 26.7, 26.8, latest— the 3 newest series plus the 2 newest LTS series. All new version legs pass; the only red checks are the known CH-cloud credential legs, which are unrelated to this diff.The merge decision is yours. Please merge, close, or hold this PR, as you prefer. One thing that is useful to know: our weekly version check keeps no state and re-derives coverage every run, so if this is closed the repo is reported as off-policy again and the task returns. A permanent answer therefore needs an agreement between you and the ClickHouse integrations team on the coverage rule for clickhouse-java, not another PR from me. I have asked our side to start that conversation.
I will not push a change to this list unless our team agrees to the exception, and I will not keep re-opening this point with you.