Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a trusted local Streamlit workbench for uploading catalogue CSVs, correcting durable staged rows, and approving a complete batch. Server-generated row identities and locked expected revisions reject stale edits/approval; a single PostgreSQL transaction publishes new SKUs without overwriting existing catalogue items. Native XSRF/CORS protections remain enabled and only the thread-safe engine is cached.
Validation: six CSV unit cases, nine real Cloud cases (all passing) covering observed lock contention, competing approval, edit/approve ordering, a late SKU conflict with total rollback, constraints, restricted roles and certificate/hostname TLS controls. Actual Chromium upload/editor flow and two-browser stale-click rejection, desktop/mobile screenshots, process restart readback, fresh Alembic up/down/up and an empty-environment locked install passed. Ruff/compilation and source/private-value agreement passed. Earlier browser helper timing/method failures are preserved in private programme evidence.
The app is bound to loopback without application authentication. Uploads and reviews are bounded; all connected operators share authority. Companion article and infrastructure credentials remain local, outside this PR.
Browser-helper follow-up: Python Playwright is now pinned to 1.56.0. Only helper requirement pins changed; runtime application code/dependencies are unchanged. Clean isolated native-Linux installs, pip check and Chromium launch/DOM/screenshot smoke passed for the updated helper. Full Cloud/application acceptance remains recorded at
f24a7eaaa018aa3fabe354390a74b5e71394e93c; it was not rerun for this test-dependency-only follow-up.