Conversation
4 tasks
serprex
force-pushed
the
to-char
branch
3 times, most recently
from
c2176f3 to
b40dc1e
Compare
theory
requested changes
May 10, 2026
Collaborator
theory
left a comment
theory
left a comment
There was a problem hiding this comment.
Very nice, thank you. Please document it; would be nice to document exactly what translates and what doesn't.
Member
Author
|
updated with docs |
theory
reviewed
May 11, 2026
theory
approved these changes
May 11, 2026
Translate Postgres `to_char(timestamp[tz], fmt)`` to ClickHouse `formatDateTime()` when `fmt` is a constant in which every formatting keyword has a ClickHouse equivalent: `YYYY/YY`, `MM`, `DD`, `DDD`, `HH24`, `HH12/HH`, `MI`, `SS`, `Q`, `Mon`, `Dy`, and `AM/PM` --- plus lowercase variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translates PG to_char(timestamp[tz], fmt) to CH formatDateTime when fmt is a constant whose every keyword has CH equivalent: YYYY/YY, MM, DD, DDD, HH24, HH12/HH, MI, SS, Q, Mon, Dy, AM/PM, plus lowercase variants