Skip to content

Do not run tests twice when PR submitted#246

Open
serprex wants to merge 1 commit into
mainfrom
do-not-run-tests-twice
Open

Do not run tests twice when PR submitted#246
serprex wants to merge 1 commit into
mainfrom
do-not-run-tests-twice

Conversation

@serprex
Copy link
Copy Markdown
Member

@serprex serprex commented May 9, 2026

@serprex serprex requested a review from theory May 9, 2026 22:45
@serprex serprex marked this pull request as ready for review May 9, 2026 22:45
@serprex serprex force-pushed the do-not-run-tests-twice branch from dcd8768 to 25f3cd3 Compare May 9, 2026 23:19
Copy link
Copy Markdown
Collaborator

@theory theory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent tests from running when there is no PR. though. I often have WIP branches that I may or may not want tests to run on before creating a PR.

@theory theory added the quality Quality controls, testing, test coverage label May 10, 2026
@serprex
Copy link
Copy Markdown
Member Author

serprex commented May 10, 2026

This will prevent tests from running when there is no PR. though. I often have WIP branches that I may or may not want tests to run on before creating a PR.

I usually use drafts for that, but fair enough

@theory
Copy link
Copy Markdown
Collaborator

theory commented May 11, 2026

What I've done on other projects is suppress tests in a branch starting with wip/. Here, perhaps it makes sense to allow them with some other prefix.

@theory
Copy link
Copy Markdown
Collaborator

theory commented May 11, 2026

Maybe

    branches: [main, ci/**]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quality Quality controls, testing, test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants