Repository navigation
feat: dogfood Eagle Eye architecture rules in CI - #49
Closed
gabrielbmoro wants to merge 1 commit into
Closed
gabrielbmoro wants to merge 1 commit into
gabrielbmoro wants to merge 1 commit into
Conversation
Add eagle_eye_config.json enforcing the documented layer graph and run the CLI in the PR workflow. Move OutputRenderer from util/ to analyzer/ so util/ has no internal imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eagle_eye_config.jsonenforcing the documented layer graph (model,util,data,analyzer).dart run eagle_eye:mainin the PR workflow.OutputRendererfromlib/util/tolib/analyzer/soutil/has no internal imports, resolving the only existing violation.Rules
model-only-imports-modelutil-no-internal-importsdata-only-modelanalyzer-layersComposition-root files (
lib/eagle_eye_launcher.dart,lib/service_locator.dart) are intentionally unmatched.Verification
dart analyze— no issuesdart test— 64/64 passingdart run eagle_eye:main— exits 0 (4 rules, 28 files, 0 violations)Note
Moving
OutputRendererchanges its public import path frompackage:eagle_eye/util/output_renderer.darttopackage:eagle_eye/analyzer/output_renderer.dart. Consider a minor version bump when releasing.