303 dev change database and cognito to use email to login#321
303 dev change database and cognito to use email to login#321prooflesben wants to merge 14 commits intomainfrom
Conversation
…-for-notifications-module' into 303-dev---change-database-and-cognito-to-use-email-to-login
…ged the cognito user pool and changed the dynamo db table, merged in camilas ticket for login and it works with my current example
…tifiaction object so it has userEmail instead of userId
…rson who requested the delete using the id token
…ue to the fact redesigns and refactors are coming
There was a problem hiding this comment.
After doing some testing everything seems to be working once the Register change is implemented. We might find some more bugs when it comes to frontend Users page once that work is started
The only issue I found
- NotificationPopup.tsx, line 35 references userId
I think you've already fixed the below but noting for documentation here:
- Register has improper username const
- authContext.tsx has numerous username references that should be updated
All of these should be fixed |
adityapat24
left a comment
There was a problem hiding this comment.
Looks good, ran all tests in backend and frontend was all set as well
camila-carrillo
left a comment
There was a problem hiding this comment.
everything looks good to me
ℹ️ Issue
Closes
📝 Description
This ticket is basically the migration from away from using the username in our app. I tried to get it all in one go but most likely I will miss things so I pls urge you to look through the files changed and if you see somewhere that uses the user Id especially in the front end pls request changes. In this pr I also updated our user object to include the newly agreed upon fields of firstName, lastName, and profilePicUrl. The profile pic url is optional since we don't require it upon sign up. I have code to upload a profile pic but that will be a seperate pr since this is already hefty. PLS PLS PLS PLS PLS review this pr fr fr.
Briefly list the changes made to the code:
✔️ Verification
A whole lot of manual testing
Provide screenshots of any new components, styling changes, or pages.
Test Changes
If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.
🏕️ (Optional) Future Work / Notes
Didn't change references to user id in the user page related components due to a incoming redesign