Skip to content

Comments

118 Create Header Component#139

Open
saumyapalk23 wants to merge 4 commits intomainfrom
sp-118-creates-header-component
Open

118 Create Header Component#139
saumyapalk23 wants to merge 4 commits intomainfrom
sp-118-creates-header-component

Conversation

@saumyapalk23
Copy link

ℹ️ Issue

Closes #118

📝 Added header component according to figma.

Briefly list the changes made to the code:

  1. Added header.tsx & header.test.tsx.
  2. Wrote .test.tsx jest tests.
  3. Matches the figma & is flexible

✔️ Verification

image

🏕️ (Optional) Future Work / Notes

n/a

@github-actions github-actions bot requested a review from denniwang February 19, 2026 22:46
github-actions bot added a commit that referenced this pull request Feb 19, 2026
Copy link
Collaborator

@nourshoreibah nourshoreibah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but overall great work!

@@ -2,7 +2,6 @@ import { APIGatewayProxyEvent, APIGatewayProxyResult } from 'aws-lambda';
import db from './db';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm is there any chance you're not on a clean branch? These changes don't look related to the header component

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with db.ts, openai.yaml changes

Visual Verification
</h2>
<p className="text-gray-600">
The header above should show <strong>"BRANCH Accounting Platform"</strong> and the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great for testing but can we remove this extra text for now? Shouldn't need any changes to this file!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Header Component

2 participants